Skip to content

Revert #665: undo the premature develop -> main promotion - #667

Closed
jonit-dev wants to merge 1 commit into
mainfrom
revert-pr665
Closed

jonit-dev wants to merge 1 commit into
mainfrom
revert-pr665

Conversation

@jonit-dev

Copy link
Copy Markdown
Contributor

Reverts the promotion merge af1b7800 (#665), at the owner's request, because it was merged at 19:09:56 with no review and no board — and because it reset develop back to 01feceec on the way, dropping squash 623954c8 from the branch while main kept it.

The work is not lost: every commit of that promotion is an ancestor of develop (c1c25a65 merged main back in), and git diff main develop is currently empty.

This revert puts main back to exactly the tree it had before the promotion — verified: git diff af1b78005^1 HEAD is empty (byte-identical). It is a tree-only change; no commit is deleted.

After this lands, #666 (develop → main) is a real promotion again: it will show the full library diff (the 198 files of the crowd/forest work plus PRD-880) and can be merged through the queue so main publishes with a board behind it.

[skip ci] is in the commit message: on the owner's instruction for tonight's branch surgery. Say the word if you want the full board on this revert instead, and I will drop the marker and re-push.

Undo the premature develop -> main promotion: it was merged at 19:09:56 with
no review and no board, and it reset develop back to 01fecee on its way. The
work is untouched on develop (squash 623954c for PRD-880 included); main simply
goes back to the tree it had before the promotion.

This reverts commit af1b780, reversing changes made to the first parent.

Verified: the tree is byte-identical to af1b780^1 (a37b52c).

[skip ci]
@jonit-dev

Copy link
Copy Markdown
Contributor Author

Closing this: npm has 0.3.12 published and this repo is at 0.3.13, so a green main publishes the library by itself (PRD-630). Reverting the promotion would take the library off main right when it needs to be published, and cost two full boards. The sync PR #666 carries the promotion instead. Still open for the future: the premature merge and the develop rollback are recorded on #665 and in #666's description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant